TRUNK-5544:Upgraded the javassist from 3.22.0-GA to 3.25.0-GA #2957
Conversation
|
Did you add the ticket ID in the description? |
|
Which one is the ticket id ? |
|
Have you taken a look at this https://wiki.openmrs.org/display/docs/Pull+Request+Tips? |
api/pom.xml
Outdated
| <groupId>mysql</groupId> | ||
| <artifactId>mysql-connector-java</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
@reagan-meant Couple of things ,
-
Please format the code before committing. Please use this formatter.
-
Also i think this dependency is not necessary. I've cloned your branch and removed this dependency and built it. It worked fine. Can you please try
mvn clean installand see whether you are getting the same error ?
api/pom.xml
Outdated
| <groupId>mysql</groupId> | ||
| <artifactId>mysql-connector-java</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
probably this change here can be another ticket separate from this ticket herein being solved!
There was a problem hiding this comment.
Alright then....
|
Can you include the ticket id in the commit message as advised at? https://wiki.openmrs.org/display/docs/Pull+Request+Tips |
|
Are these changes for javassist or mysql connector? |
|
@dkayiwa I made that addition of mysql-connector because of this issue...https://issues.openmrs.org/browse/TRUNK-5558?filter=-1 |
|
Those changes should not be in your pull request. |
|
@dkayiwa ...hope this is fine now |
Upgrade library org.javassist:javassist from 3.22.0-GA to 3.25.0-GA
TRUNK-5544:Upgrade org.javassist:javassist
I upgraded the org.javassist:javassist library from 3.22.0-GA to 3.25.0-GA
I also included the mysql connector in my api pom with the scope as test because the tests fail with out it...errors shown here https://pastebin.com/nNxrKv1d
https://issues.openmrs.org/browse/TRUNK-5544